Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upstream git repository for safe-rm #101386

Closed
wants to merge 1 commit into from
Closed

Conversation

@fmarier
Copy link
Contributor

@fmarier fmarier commented Oct 22, 2020

Gitorious is long gone and the upstream repository is now on Launchpad: https://code.launchpad.net/safe-rm

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 22, 2020

There are other links which point to Gitorious. We should replace them, too if they are still available.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 22, 2020

Can you change the commit headline to?

safe-rm: Update git repository 

Gitorious is long gone and the upstream repository is now on Launchpad: https://code.launchpad.net/safe-rm
@fmarier
Copy link
Contributor Author

@fmarier fmarier commented Oct 22, 2020

Can you change the commit headline to?

safe-rm: Update git repository 

Updated.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

@SuperSandro2000 please avoid changing the base branch to avoid spamming tens of maintainers. Thank you :)

Sometimes it works but 3 out of 4 times it does not. I wish GitHub had a feature where I can just pick that one commit into another branch.

@roberth
Copy link
Member

@roberth roberth commented Nov 27, 2020

I wish GitHub had a feature where I can just pick that one commit into another branch.

That would be nice, but for now let's do that on the command line.

Did anyone try convert to draft before rebasing? Might be worth a shot.

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 27, 2020

Sometimes it works but 3 out of 4 times it does not.

Yes, sometimes it works because we merge master into the other branches. We need a GH Action to do these merges more often #104594

@roberth
Copy link
Member

@roberth roberth commented Nov 27, 2020

@FRidh that doesn't work for cases where contributors target a release branch first instead of master, like this one.

@erictapen
Copy link
Member

@erictapen erictapen commented Jan 14, 2021

Backported to 20.09 in 471e36f.

@alyssais
Copy link
Member

@alyssais alyssais commented Jan 14, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants