Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

cinnamon.cinnamon-settings-daemon: fix csd-backlight-helper build, fixes #101128 #101394

Merged
merged 1 commit into from Oct 26, 2020

Conversation

@mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Oct 22, 2020

馃挴 points for @worldofpeace, this fixes the compile issue with csd-backlight-helper

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mkg20001
Copy link
Member Author

@mkg20001 mkg20001 commented Oct 22, 2020

Getting

Warning: no backlight sources have been configured.
Check org.cinnamon.settings-daemon.plugins.power to configure some.
Could not get or set the value of the backlight: No backlight devices present

but my laptop seems to not have any backlight support whatsoever even with light -S so could someone test this with a working backlight?

basically:

result/libexec/csd-backlight-helper --get-max-brightness

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 22, 2020

We're missing a schema for the wrapper

./result/libexec/csd-power
(csd-power:17877): GLib-GIO-ERROR **: 12:10:39.813: Settings schema 'org.cinnamon.SessionManager' is not installed

cinnamon-session

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 22, 2020

If you open htop I'm guessing it didn't start 馃槮

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 22, 2020

omg it's a circular dependency because cinnamon-session needs cinnamon-settings-daemon and so on 馃ぃ

@mkg20001
Copy link
Member Author

@mkg20001 mkg20001 commented Oct 23, 2020

image

csd-power works thanks to env variables mixing everything up. not sure if I should be happy or sad about that.

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 23, 2020

So I believe you will only see the error you mentioned if it wasn't running.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

I'm running this rn and the backlight works. Though in a very sad state because of the circular dependency.

@worldofpeace worldofpeace merged commit 718f43d into NixOS:master Oct 26, 2020
19 checks passed
@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 26, 2020

backported to 20.09 in e3ce7e1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants