Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibus: fix typo in example #101404

Closed
wants to merge 1 commit into from
Closed

ibus: fix typo in example #101404

wants to merge 1 commit into from

Conversation

@pickfire
Copy link
Contributor

@pickfire pickfire commented Oct 22, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@pickfire
Copy link
Contributor Author

@pickfire pickfire commented Oct 23, 2020

Oh, I just realized the kimpanel here does not work for ibus.

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 23, 2020

This is intentional:

e38970c

It evokes escaping in '' strings but I am not sure how exactly does it work since it is not actually escaped as far as Nix syntax is concerned.

@SuperSandro2000 SuperSandro2000 requested a review from jtojnar Nov 27, 2020
@doronbehar doronbehar closed this Dec 18, 2020
@pickfire pickfire deleted the patch-2 branch Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants