Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use libsForQt512 #101411

Closed
wants to merge 3 commits into from
Closed

use libsForQt512 #101411

wants to merge 3 commits into from

Conversation

@aanderse
Copy link
Member

@aanderse aanderse commented Oct 22, 2020

Motivation for this change

Since upgrading to 20.09 I have noticed:

  • okteta crashes on startup
  • k4dirstat looks terrible
  • dolphinEmuMaster looks terrible

These changes seem to fix the above issues.

This needs a backport to 20.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 22, 2020

  1. The dolphin issue seems unrelated to #100707.
  2. The okteta issue is definitely related to #100707 but currently the list of affected packages there doesn't list it because it was generated by ofborg when kdeFrameworks didn't use qt515 by default.
  3. The k4dirstat issue is the same as okteta.

@aanderse Could you please push the okteta and k4dirstat commits to #101369 ? An additional check of these packages with libsForQt5 (515) would be worth it while at it.

There's a Nix script that may be handy to you / me / us if one wishes to verify incompatible qt versions are used together:

NixOS/ofborg#533 (comment)

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 23, 2020

Both okteta and k4dirstat build and run and look fine on #101369 , with qt515.

@aanderse
Copy link
Member Author

@aanderse aanderse commented Oct 24, 2020

Thanks for your feedback @doronbehar. I'll remove okteta and k4dirstat from this PR.

For reference I have built dolphinEmuMaster 3 ways on/against 20.09 to see the ui:

nix-build -E 'with import <nixpkgs> {}; libsForQt512.callPackage <nixpkgs/pkgs/misc/emulators/dolphin-emu/master.nix> { CoreBluetooth = null; ForceFeedback = null; IOKit = null; OpenGL = null; }'
nix-build -E 'with import <nixpkgs> {}; libsForQt514.callPackage <nixpkgs/pkgs/misc/emulators/dolphin-emu/master.nix> { CoreBluetooth = null; ForceFeedback = null; IOKit = null; OpenGL = null; }'
nix-build -E 'with import <nixpkgs> {}; libsForQt515.callPackage <nixpkgs/pkgs/misc/emulators/dolphin-emu/master.nix> { CoreBluetooth = null; ForceFeedback = null; IOKit = null; OpenGL = null; }'

Only building against libsForQt512 looked correct. When I build dolphinEmuMaster on unstable the ui also looks bad.

So do you agree I should keep this PR, but only the dolphinEmuMaster commit (dropping the other 2) and then backport to 20.09?

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 25, 2020

Only building against libsForQt512 looked correct. When I build dolphinEmuMaster on unstable the ui also looks bad.

I can't reproduce this on #101369 - building with either qt5 there gives an OK looking UI, to my view. Perhaps your environment is polluted, but that doesn't matter with #101369.

@aanderse
Copy link
Member Author

@aanderse aanderse commented Oct 25, 2020

Thanks for letting me know. Will that PR get back ported to 20.09? It looks massive...

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 25, 2020

@aanderse
Copy link
Member Author

@aanderse aanderse commented Oct 25, 2020

Thanks!

@aanderse aanderse closed this Oct 25, 2020
@aanderse aanderse deleted the libsForQt512 branch Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants