Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdsync: 0.11.1 -> 0.11.2 #101419

Merged
merged 1 commit into from Oct 25, 2020
Merged

bdsync: 0.11.1 -> 0.11.2 #101419

merged 1 commit into from Oct 25, 2020

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 22, 2020

Motivation for this change

https://r.ryantm.com/log/2020-10-21.log

https://github.com/rolffokkens/bdsync/releases/tag/v0.11.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
dbirks
dbirks approved these changes Oct 24, 2020
Copy link
Member

@dbirks dbirks left a comment

Built and executed nicely for me, and the change to rolffokkens looks good, with rolffokkens/bdsync being the upstream of TargetHolding/bdsync.

@bhipple bhipple merged commit d895524 into NixOS:master Oct 25, 2020
19 checks passed
@SuperSandro2000 SuperSandro2000 deleted the bdsync-0.11.2 branch Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants