Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geogebra: 5-0-593-0 -> 5-0-609-0, geogebra6: 6-0-600-0 -> 6-0-609-0 #101421

Merged
merged 1 commit into from Oct 30, 2020

Conversation

@sikmir
Copy link
Member

@sikmir sikmir commented Oct 22, 2020

Motivation for this change
  • geogebra: 5-0-593-0 -> 5-0-609-0, enable on darwin
  • geogebra6: 6-0-600-0 -> 6-0-609-0, enable on darwin
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sikmir sikmir requested a review from Ma27 Oct 22, 2020
@Ma27 Ma27 merged commit 952dc5c into NixOS:master Oct 30, 2020
16 checks passed
@sikmir sikmir deleted the geogebra branch Oct 31, 2020
voidIess
Copy link
Contributor

voidIess commented on a2472eb Jan 1, 2021

did you test darwin @sikmir ? I had some strange bug, where the window wouldnt get any input, because it wont gain focus.

voidIess
Copy link
Contributor

voidIess commented on a2472eb Jan 1, 2021

(I've tried this with two systems)

@sikmir
Copy link
Member Author

@sikmir sikmir commented Jan 1, 2021

did you test darwin @sikmir ? I had some strange bug, where the window wouldnt get any input, because it wont gain focus.

Yes, it works for me on my macOS High Sierra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants