Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtss: init at 0.6.1 #101431

Merged
merged 1 commit into from Dec 27, 2020
Merged

rtss: init at 0.6.1 #101431

merged 1 commit into from Dec 27, 2020

Conversation

@djanatyn
Copy link
Contributor

@djanatyn djanatyn commented Oct 23, 2020

Motivation for this change

rtss provides a way to understand the performance of complex shell pipelines and loops.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@djanatyn
Copy link
Contributor Author

@djanatyn djanatyn commented Oct 23, 2020

I turned off checks as they were failing:

running tests
Running cargo test --release --target x86_64-unknown-linux-gnu --frozen --
   Compiling rtss v0.6.1 (/build/source)
    Finished release [optimized] target(s) in 0.49s
     Running target/x86_64-unknown-linux-gnu/release/deps/rtss-93270af92de2f40e

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/x86_64-unknown-linux-gnu/release/deps/rtss-8d2a66c3d913ebdd

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests rtss

running 1 test
test src/lib.rs - RtssWriter<W>::new (line 107) ... FAILED

failures:

---- src/lib.rs - RtssWriter<W>::new (line 107) stdout ----
error[E0308]: mismatched types
 --> src/lib.rs:115:81
  |
9 |     let mut writer = RtssWriter::new(io::stdout(), Duration::human_string, '|', &Instant::now());
  |                                                                                 ^^^^^^^^^^^^^^^
  |                                                                                 |
  |                                                                                 expected struct `std::time::Instant`, found `&std::time::Instant`
  |                                                                                 help: consider removing the borrow: `Instant::now()`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0308`.
Couldn't compile the test.

failures:
    src/lib.rs - RtssWriter<W>::new (line 107)

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--doc'
builder for '/nix/store/fj72f3mlkjlckskd29w3wfizqabfg6c4-rtss-0.6.1.drv' failed with exit code 101
error: build of '/nix/store/fj72f3mlkjlckskd29w3wfizqabfg6c4-rtss-0.6.1.drv' failed

I think the upstream repository may be running tests against dead code?

@djanatyn
Copy link
Contributor Author

@djanatyn djanatyn commented Oct 27, 2020

Updated!

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 27, 2020

Run on darwin:

Result of nixpkgs-review pr 101431 1

1 package built:
  • rtss

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 101431 run on x86_64-linux 1

1 package built:
  • rtss

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 27, 2020

Result of nixpkgs-review pr 101431 run on x86_64-darwin 1

1 package built:
  • rtss

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 27, 2020

Result of nixpkgs-review pr 101431 run on x86_64-linux 1

1 package built:
  • rtss

@SuperSandro2000 SuperSandro2000 merged commit a1e8f89 into NixOS:master Dec 27, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants