Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: disable LTO by default due to segfaults with wayland #101434

Merged
merged 1 commit into from Oct 23, 2020

Conversation

@andir
Copy link
Member

@andir andir commented Oct 23, 2020

Motivation for this change

As discussed in #101429 firefox 82 started crashing when used with
wayland. A brief investigation showed that this appears to be rooted
within the LTO support that was recently added to the package. For the
time being, until someone figures out where the crashes are coming from,
we can just disable LTO.

cc @artemist

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
As discussed in NixOS#101429 firefox 82 started crashing when used with
wayland. A brief investigation showed that this appears to be rooted
within the LTO support that was recently added to the package. For the
time being, until someone figures out where the crashes are coming from,
we can just disable LTO.
@andir andir requested a review from artemist Oct 23, 2020
@artemist
Copy link
Member

@artemist artemist commented Oct 23, 2020

I'm building this right now, I'll report back once it's done

@andir
Copy link
Member Author

@andir andir commented Oct 23, 2020

I did dig a bit more and it seems like Fedora also started disabling LTO with the release of Firefox82 https://src.fedoraproject.org/rpms/firefox/c/65fabb34c1267a295007bc97b53cedc5a79e4154?branch=master

Copy link
Member

@artemist artemist left a comment

I built this locally and was able to run with Wayland

@andir
Copy link
Member Author

@andir andir commented Oct 23, 2020

Pining @S-NA as he introduced LTO. Maybe he can have a look at this.

@andir andir merged commit e7a4b3d into NixOS:master Oct 23, 2020
17 checks passed
@andir andir deleted the firefox-disable-lto branch Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants