Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.transformers: 3.3.1 -> 3.4.0 #101443

Merged
merged 3 commits into from Oct 28, 2020

Conversation

@danieldk
Copy link
Member

@danieldk danieldk commented Oct 23, 2020

Motivation for this change

Update transformers and its tokenizers dependency.

Changelog:

https://github.com/huggingface/transformers/releases/tag/v3.4.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
danieldk added 3 commits Oct 23, 2020
Changelog:

https://github.com/huggingface/tokenizers/releases/tag/python-v0.9.0
https://github.com/huggingface/tokenizers/releases/tag/python-v0.9.1
https://github.com/huggingface/tokenizers/releases/tag/python-v0.9.2

Changes in the derivation:

* Tokenizers uses a newer version of pyo3 that does not require Rust
  nightly anymore. So, we do not have to use any cheat codes anymore.
* Tokenizers is now a mixed Rust/Python project. The way it is set
  up does not work with Maturin, so switch to setuptools-rust instead.
* Add additional data files needed for tests.
* Use `pytestCheckHook`.
@danieldk
Copy link
Member Author

@danieldk danieldk commented Oct 23, 2020

@ofborg build python37Packages.transformers python38Packages.transformers

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 28, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/350

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 101443 1

7 packages built:
  • python27Packages.setuptools-rust
  • python37Packages.setuptools-rust
  • python37Packages.tokenizers
  • python37Packages.transformers
  • python38Packages.setuptools-rust
  • python38Packages.tokenizers
  • python38Packages.transformers

@jonringer jonringer merged commit 05f6de9 into NixOS:master Oct 28, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4400731"; rev="44007313a54ae6041ce1ea6b797d8556c6b6dc0b"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4400731"; rev="44007313a54ae6041ce1ea6b797d8556c6b6dc0b"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4400731"; rev="44007313a54ae6041ce1ea6b797d8556c6b6dc0b"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4400731"; rev="44007313a54ae6041ce1ea6b797d8556c6b6dc0b"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4400731"; rev="44007313a54ae6041ce1ea6b797d8556c6b6dc0b"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4400731"; rev="44007313a54ae6041ce1ea6b797d8556c6b6dc0b"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4400731"; rev="44007313a54ae6041ce1ea6b797d8556c6b6dc0b"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
python37Packages.transformers, python38Packages.transformers on aarch64-linux Success
Details
@ofborg[bot]
python37Packages.transformers, python38Packages.transformers on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants