Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yed: wrap With wrapGAppsHook - fixes #101135 #101456

Merged
merged 1 commit into from Nov 5, 2020
Merged

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 23, 2020

Use preFixup to setup the wrapper properly, without double wrapping.

Motivation for this change

Fix #101135 (cc @bluescreen303 ).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Use preFixup to setup the wrapper properly, without double wrapping.
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Nov 5, 2020

I tested this to fix the issue myself, and the maintainer of yed and the OP of #101135 won't respond / object, so I'm merging.

@doronbehar doronbehar merged commit 450c9c9 into NixOS:master Nov 5, 2020
19 of 20 checks passed
@doronbehar doronbehar deleted the pkg/yed branch Nov 5, 2020
iafuente
Copy link

iafuente commented on 919df81 Nov 25, 2020

Hi! Can be the duplicated passthrus (L34 and L155) merged into unique because of issue #104680?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants