Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fiche: init at version 0.9.1 #101469

Merged
merged 3 commits into from Jan 18, 2021
Merged

fiche: init at version 0.9.1 #101469

merged 3 commits into from Jan 18, 2021

Conversation

@pinpox
Copy link
Member

@pinpox pinpox commented Oct 23, 2020

Motivation for this change

Include fiche, a command line pastebin service for sharing terminal output with minimal dependencies.

Note: this is my first PR to nixpkgs, feedback is welcome so please let me know what has to be changed!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@pinpox pinpox changed the title initial commit based on gnu-hello fiche: init at version 0.9.1 Oct 23, 2020
pkgs/servers/fiche/default.nix Outdated Show resolved Hide resolved
pkgs/servers/fiche/default.nix Outdated Show resolved Hide resolved
pkgs/servers/fiche/default.nix Outdated Show resolved Hide resolved
pkgs/servers/fiche/default.nix Outdated Show resolved Hide resolved
@pinpox
Copy link
Member Author

@pinpox pinpox commented Oct 23, 2020

The package builds and works fine now on my machine.

@pinpox
Copy link
Member Author

@pinpox pinpox commented Oct 23, 2020

I'd like to add a service aswell, so that this can be used declaratively from your configuration.nix like:

services = {
  fiche = {
    enable = true;
    domain = "example.com";
    listen_addr  = "0.0.0.0";
    port = "9999";
    slug size = 3;
    output directory = "/var/dir/";
    buffer size = 2048;
    user name = fiche;
    log file = home/www/fiche-log.txt;
    banlist = [];
    whitelist = [];
    https = true; # -S command line option
  };
};

Should that be a separate PR? and how/where do I add such a configuration option?

@turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Oct 23, 2020

I would recommend doing separate PR for service. It will likely require other set of reviewers. I would also recommend trying to first define service as part of your personal configuration first and only then trying to port it to nixos modules.

pkgs/servers/fiche/default.nix Outdated Show resolved Hide resolved
@turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Oct 23, 2020

@pinpox Please squash commits into a single one with the message fiche: init at version 0.9.1 and I think this is good to go from my point of view.

@pinpox pinpox force-pushed the pinpox-fiche-init branch from 4e23933 to f5a50ce Oct 23, 2020
@pinpox pinpox force-pushed the pinpox-fiche-init branch from cda356a to 07d22cf Oct 23, 2020
@pinpox
Copy link
Member Author

@pinpox pinpox commented Oct 23, 2020

@pinpox Please squash commits into a single one with the message fiche: init at version 0.9.1 and I think this is good to go from my point of view.

I found a small bug, fixed now and squashed.

@turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Oct 23, 2020

yup that's cool. I also found it but looks I didin't have to point it out #101469 (comment)

👍 good work on this. It will probably take a few days for committers to merge this because they're quite overloaded with PRs so please be patient.

pkgs/servers/fiche/default.nix Outdated Show resolved Hide resolved
pinpox and others added 2 commits Oct 27, 2020
Co-authored-by: Nikolay Korotkiy <sikmir@gmail.com>
@pinpox
Copy link
Member Author

@pinpox pinpox commented Nov 20, 2020

Can someone merge this or comment on what is missing?

@pinpox pinpox requested a review from SuperSandro2000 Dec 20, 2020
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Also please squash the commits related to the package together into the init commit.

otherwise LGTM

@@ -6751,6 +6751,16 @@
fingerprint = "A3A3 65AE 16ED A7A0 C29C 88F1 9712 452E 8BE3 372E";
}];
};
pinpox = {
Copy link
Member

@SuperSandro2000 SuperSandro2000 Dec 20, 2020

Please put this into a separate commit with the message maintainers: add pinpox.

@@ -142,6 +142,8 @@ in

ankisyncd = callPackage ../servers/ankisyncd { };

fiche = callPackage ../servers/fiche { };
Copy link
Member

@SuperSandro2000 SuperSandro2000 Dec 20, 2020

It would be great if you could sort this into a fitting category and alphabetically there.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 20, 2020

Result of nixpkgs-review pr 101469 run on x86_64-darwin 1

1 package built:
  • fiche

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 20, 2020

Result of nixpkgs-review pr 101469 run on x86_64-linux 1

1 package built:
  • fiche

@SuperSandro2000 SuperSandro2000 merged commit ccafb23 into NixOS:master Jan 18, 2021
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
fiche, fiche.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
fiche, fiche.passthru.tests on x86_64-linux Success
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90c3182"; rev="90c318246727ec5d1dae6706ebe1d8f1ffc3d6f6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90c3182"; rev="90c318246727ec5d1dae6706ebe1d8f1ffc3d6f6"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90c3182"; rev="90c318246727ec5d1dae6706ebe1d8f1ffc3d6f6"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90c3182"; rev="90c318246727ec5d1dae6706ebe1d8f1ffc3d6f6"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90c3182"; rev="90c318246727ec5d1dae6706ebe1d8f1ffc3d6f6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90c3182"; rev="90c318246727ec5d1dae6706ebe1d8f1ffc3d6f6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="90c3182"; rev="90c318246727ec5d1dae6706ebe1d8f1ffc3d6f6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants