Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p4: 2020.1.1991450 -> 2020.1.2007551 #101470

merged 1 commit into from Oct 23, 2020

p4: 2020.1.1991450 -> 2020.1.2007551 #101470

merged 1 commit into from Oct 23, 2020


Copy link

@endocrimes endocrimes commented Oct 23, 2020

Motivation for this change

I've had this as a local override for a while, pushing this as I work through upstreaming changes again. The download URL hasn't changed, but unfortunately the artifact it serves does.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
The download URL hasn't changed, but the sha256 and user facing download
version has. See [perforce downloads][p4-download].

@grahamc grahamc merged commit 4770d41 into NixOS:master Oct 23, 2020
19 checks passed
@endocrimes endocrimes deleted the dani/bump-p4 branch Oct 23, 2020
Copy link

@corngood corngood commented Oct 28, 2020

#101955 suggests cherry-picking this into 20.09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants