Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pystray: mark linux only #101476

Merged
merged 1 commit into from Oct 23, 2020

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 23, 2020

Motivation for this change

Fails to build on Darwin and pyobjc-framework seems like a large collection of packages which should be treated specially and not be introduced one by one to nixpkgs.

installing
Executing pipInstallPhase
/private/var/folders/r4/k85s52jx3555ckj0wty615s00000gp/T/nix-build-python3.8-pystray-0.16.0.drv-0/source/dist /private/var/folders/r4/k85s52jx3555ckj0wty615s00000gp/T/nix-build-python3.8-pystray-0.16.0.drv-0/source
Processing ./pystray-0.16.0-py2.py3-none-any.whl
ERROR: Could not find a version that satisfies the requirement pyobjc-framework-Quartz>=3.0; sys_platform == "darwin" (from pystray==0.16.0) (from versions: none)
ERROR: No matching distribution found for pyobjc-framework-Quartz>=3.0; sys_platform == "darwin" (from pystray==0.16.0)
builder for '/nix/store/a7xs4l3hvvqa54nvv865rcz81jws1jbr-python3.8-pystray-0.16.0.drv' failed with exit code 1
error: build of '/nix/store/a7xs4l3hvvqa54nvv865rcz81jws1jbr-python3.8-pystray-0.16.0.drv' failed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM

@jonringer jonringer merged commit b2aa3c9 into NixOS:master Oct 23, 2020
12 of 15 checks passed
@SuperSandro2000 SuperSandro2000 deleted the pystray-linux branch Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants