Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plasma-workspace: add glib-networking and gstreamer as dependancies (for environment variable) #101477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@marius851000
Copy link
Contributor

@marius851000 marius851000 commented Oct 23, 2020

Motivation for this change

I wanted to use the radio plugin for plasma desktop. It use qtmultimediaplayer, who need gstreamer plugins and glib-networking as runtime dependancies. As I was unable to find how to make glib depend on glib-networking at compile time (cycling dependancies, althought some stuff should be doable by compiling a minimal glib-networking version in the same derivation of glib, I decended it may be a subject for another day). With this, I can play the radio I want, which use https. (I also need to load the vaapi gst plugin at runtime, via a global environment variable).

Some more info about my research to have those depencies: #72579

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) (nixos/tests/plasma5.nix)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (haven't done this manually, but I switched my system to my fork, and it have no problem).
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

A question I have is: Should I add the vaapi plugin for gst here ? My audio stream also require it, but it isn't a default installation of wrapGApps, and may add unwanted use of storage.

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 23, 2020

How does the radio plugin work? Is there a way to wrap it or add the dependencies to its path instead?

@marius851000
Copy link
Contributor Author

@marius851000 marius851000 commented Oct 24, 2020

It is a plasma extension written in QML2. I haven't spend a lot of time looking at this to see if I could dynamically load QT library or set environment variable, but it is clearly using only an interpreted, domain specific language. This language is QT specific.

@ttuegel
Copy link
Member

@ttuegel ttuegel commented Dec 5, 2020

Does the radio plugin come with plasma-workspace, or is it a separate add-on?

It use qtmultimediaplayer, who need gstreamer plugins and glib-networking as runtime dependancies.

Why not add these as dependencies of qtmultimedia then?

@stale
Copy link

@stale stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants