Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pango: 1.45.3 -> 1.47.0 #101500

Merged
merged 1 commit into from Oct 24, 2020
Merged

pango: 1.45.3 -> 1.47.0 #101500

merged 1 commit into from Oct 24, 2020

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 23, 2020

Motivation for this change

Version bump with a bugfix, see #101458

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS (aarch64-linux, x86_64-linux, i686-linux)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 23, 2020

Changes look okay:

(https://ftp.gnome.org/pub/GNOME/sources/pango/1.45/pango-1.45.4.news)
Overview of changes in 1.45.4

  • Fix build on Windows
  • Fix a pidgin crash
  • fc: Always reject unsupported font formats
  • coretext: Fix cairo scaling

(https://ftp.gnome.org/pub/GNOME/sources/pango/1.45/pango-1.45.5.news)
Overview of changes in 1.45.5

  • Export pango_color_parse_with_alpha
  • Stop using hb-glib

(https://ftp.gnome.org/pub/GNOME/sources/pango/1.46/pango-1.46.0.news)
Overview of changes in 1.46.0

  • Bump version to 1.46

(https://ftp.gnome.org/pub/GNOME/sources/pango/1.46/pango-1.46.1.news)
Overview of changes in 1.46.1

  • Revert an unintentional PangoRenderer abi break in 1.46.0
  • Various small fixes

(https://ftp.gnome.org/pub/GNOME/sources/pango/1.46/pango-1.46.2.news)
Overview of changes in 1.46.2

  • Fix pango_win32_font_map_load_font with falback families
  • Fix an assertion in pango_language_get_scripts
  • Fix a crash in get_items_log_attrs
  • Fix attribute iterators with overlapping attributes
  • Fix rendering of Emoji keycap sequences
  • ci: Run the testsuite under asan and fix all reported issues
  • build: Make libthai, cairo, xft, fontconfig, freetype
    dependencies meson features

(https://ftp.gnome.org/pub/GNOME/sources/pango/1.47/pango-1.47.0.news)
Overview of changes in 1.47.0

  • Add pango_language_get_preferred
  • Add pango_fc_font_get_languages
  • Sort faces of a family by slant and weight

The only notable change seems to be https://gitlab.gnome.org/GNOME/pango/-/commit/98b3ff0b967c7ecb53e119e914d6e8cb65584ad3 in 1.45.5, which allows us to build harfbuzz without glib dependency but we do not need that.

@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Oct 23, 2020

Thank you for reviewing!

@7c6f434c 7c6f434c merged commit 9313ea2 into NixOS:staging Oct 24, 2020
19 of 20 checks passed
19 of 20 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
pango, pango.passthru.tests on x86_64-darwin
Details
@ofborg[bot]
pango, pango.passthru.tests on aarch64-linux Failure
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a89b842"; rev="a89b8422713e1b77f5bd5482e9b53f23d6c9d62d"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a89b842"; rev="a89b8422713e1b77f5bd5482e9b53f23d6c9d62d"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a89b842"; rev="a89b8422713e1b77f5bd5482e9b53f23d6c9d62d"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a89b842"; rev="a89b8422713e1b77f5bd5482e9b53f23d6c9d62d"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a89b842"; rev="a89b8422713e1b77f5bd5482e9b53f23d6c9d62d"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a89b842"; rev="a89b8422713e1b77f5bd5482e9b53f23d6c9d62d"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a89b842"; rev="a89b8422713e1b77f5bd5482e9b53f23d6c9d62d"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
pango, pango.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants