Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angle-grinder: init at 0.15.0 #101503

Merged
merged 1 commit into from Nov 2, 2020
Merged

angle-grinder: init at 0.15.0 #101503

merged 1 commit into from Nov 2, 2020

Conversation

@bbigras
Copy link
Contributor

@bbigras bbigras commented Oct 23, 2020

Motivation for this change

Angle-grinder allows you to parse, aggregate, sum, average, min/max, percentile, and sort your data. You can see it, live-updating, in your terminal. Angle grinder is designed for when, for whatever reason, you don't have your data in graphite/honeycomb/kibana/sumologic/splunk/etc. but still want to be able to do sophisticated analytics.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@endocrimes
Copy link
Member

@endocrimes endocrimes commented Oct 24, 2020

Result of nixpkgs-review pr 101503 1

1 package built:
  • angle-grinder

Copy link
Member

@endocrimes endocrimes left a comment

This works for me - There's one small issue but I don't think it's essential though:

It seems that agrind has a built in --self-update feature, which is a little bit messy in nix. If it's possible to disable, it would be nice to, otherwise we'll have to live with it being a bit weird.

@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Nov 2, 2020

It seems that agrind has a built in --self-update feature, which is a little bit messy in nix. If it's possible to disable, it would be nice to, otherwise we'll have to live with it being a bit weird.

Thanks for the review @endocrimes. It seems --self-update was made optional and then non-default. I'm expecting it to be in the next release.

see:
rcoh/angle-grinder@81209f2
rcoh/angle-grinder@f0422da

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 2, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/270

@kevincox kevincox merged commit ba84f8b into NixOS:master Nov 2, 2020
19 checks passed
@bbigras bbigras deleted the angle-grinder branch Nov 2, 2020
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Nov 2, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants