Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 32 bit mysql mariadb test using MyRocks #101504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@jfroche
Copy link
Contributor

@jfroche jfroche commented Oct 23, 2020

As stated in [1], MyRocks requires 64 bit platform to compile

[1] https://mariadb.com/kb/en/building-myrocks-in-mariadb/

ZHF: #97479
Fixes: https://hydra.nixos.org/build/128918551

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
nixos/tests/mysql/mysql.nix Outdated Show resolved Hide resolved
nixos/tests/mysql/mysql.nix Outdated Show resolved Hide resolved
@jfroche jfroche force-pushed the fix/nixos/tests/mysql branch 3 times, most recently from 5c7f97f to dc4d87d Oct 26, 2020
Copy link
Contributor

@r-burns r-burns left a comment

LGTM

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Can you fix the ofborg error? Maybe a rebase helps.

As stated in [1], MyRocks requires 64 bit platform to compile

[1] https://mariadb.com/kb/en/building-myrocks-in-mariadb/
@jfroche jfroche force-pushed the fix/nixos/tests/mysql branch from dc4d87d to 897cd77 Nov 27, 2020
@stale
Copy link

@stale stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale label Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants