Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuspell: 3.1.2 -> 4.0.0, fix license #101512

Merged
merged 1 commit into from Oct 29, 2020
Merged

nuspell: 3.1.2 -> 4.0.0, fix license #101512

merged 1 commit into from Oct 29, 2020

Conversation

@omasanori
Copy link
Contributor

@omasanori omasanori commented Oct 23, 2020

Motivation for this change

This change updates nuspell to the latest version and corrects its license metadata that was GPL-3.0-only but actually LGPL-3.0-or-later.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
The license of Nuspell is not GPL-3.0-only but LGPL-3.0-or-later.

Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 23, 2020

Fails to build on darwin:

checking whether CFLAGS is valid... yes
checking whether LDFLAGS is valid... no
configure: error: something wrong with LDFLAGS=""
builder for '/nix/store/ppbkqkmvzmy5z391xm5g3f95945h1fl9-ruby-2.6.6.drv' failed with exit code 1
```^

Builds on nix/NixOS.
@r-burns
Copy link
Contributor

@r-burns r-burns commented Oct 24, 2020

@SuperSandro2000 That's just ruby failing to build, take a look at #101330. I'll give this a go with my hacky -Wl,-w workaround for ruby.

Copy link
Contributor

@r-burns r-burns left a comment

WFM on non-nixos linux and macos 10.14 (pending fix for ruby prereq)

Result of nixpkgs-review pr 101512 1

1 package built:
  • nuspell
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 24, 2020

@SuperSandro2000 That's just ruby failing to build, take a look at #101330. I'll give this a go with my hacky -Wl,-w workaround for ruby.

Oh yeah, we need to fix ruby asap.

@dywedir
Copy link
Member

@dywedir dywedir commented Oct 29, 2020

Thanks!

@dywedir dywedir merged commit 4bbd356 into NixOS:master Oct 29, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0075ec3"; rev="0075ec3ffab4bcb5e7e0a4ee5ad4fb46cec83054"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0075ec3"; rev="0075ec3ffab4bcb5e7e0a4ee5ad4fb46cec83054"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0075ec3"; rev="0075ec3ffab4bcb5e7e0a4ee5ad4fb46cec83054"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0075ec3"; rev="0075ec3ffab4bcb5e7e0a4ee5ad4fb46cec83054"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0075ec3"; rev="0075ec3ffab4bcb5e7e0a4ee5ad4fb46cec83054"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0075ec3"; rev="0075ec3ffab4bcb5e7e0a4ee5ad4fb46cec83054"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0075ec3"; rev="0075ec3ffab4bcb5e7e0a4ee5ad4fb46cec83054"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
nuspell, nuspell.passthru.tests on aarch64-linux Success
Details
@ofborg
nuspell, nuspell.passthru.tests on x86_64-linux Success
Details
@omasanori omasanori deleted the omasanori:nuspell-4.0.0 branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants