Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.imutils: refactor #101513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@mtrsk
Copy link
Member

@mtrsk mtrsk commented Oct 23, 2020

Make sure imutils can be built with both opencv3 and opencv4. This would also close an old issue of mine.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mtrsk mtrsk requested review from FRidh and jonringer as code owners Oct 23, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 23, 2020

Builds successfully on darwin with withOpenCV4.

@mtrsk mtrsk force-pushed the update-pythonPackages-imutils branch from 8abde1a to 2f19a83 Oct 26, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 101513 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python27Packages.vidstab
5 packages built:
  • python27Packages.imutils
  • python37Packages.imutils
  • python37Packages.vidstab
  • python38Packages.imutils
  • python38Packages.vidstab

@stale
Copy link

@stale stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants