Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME polishing from Q.A findings #101516

Merged
merged 6 commits into from Oct 25, 2020
Merged

Conversation

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 24, 2020

Motivation for this change

Some stuff I thought to fixup when rereading #99648

Especially the thing about allowing DE modules to register a flatpak GUI that will be installed automatically.
Though, it's of question if there should be an option to disable that?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Oct 24, 2020

It seems bcd186f did nothing... maybe we need an internal option for initial favorite apps

This serves no purpose without flatpak NixOS#99648 (comment)
This adds basically an indirection to systemPackages
to automatically install an interface for flatpak for their respective
environments. e.g if I enable pantheon and flatpak you'll get appcenter,
and on gnome you'll see gnome-software.

NixOS#99648 (comment)
Rather messy and only needed for the installation cd, so it's
an internal option.
@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Oct 24, 2020

I had to add an option for favorite-apps, but it's internal since it's only for the installation-cd, and it would be better suited to actually have a better dconf module.

@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Oct 24, 2020

Also noticed that gnome-calendar should be in favorites as well 7df6af3

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 24, 2020

It should not really matter that the option was there twice, I think the issue were the syntax error (missing comma).

@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Oct 24, 2020

It should not really matter that the option was there twice, I think the issue were the syntax error (missing comma).

I corrected it to no effect. Maybe I should check again, but I believe I tried building vms with clean states each time.

@worldofpeace worldofpeace merged commit 4d71306 into NixOS:master Oct 25, 2020
16 checks passed
@worldofpeace worldofpeace deleted the gnome-polishing branch Oct 25, 2020
jtojnar added a commit to jtojnar/nixpkgs that referenced this issue May 18, 2021
It was basically just a `environment.systemPackages` synonym,
only GNOME used it, and it was stretching the responsibilities
of the flatpak module too far.

It also makes it cleaner to avoid installing the program
using GNOME module’s `excludePackages` option.

Partially reverts: NixOS#101516
Fixes: NixOS#110310
jtojnar added a commit to jtojnar/nixpkgs that referenced this issue May 18, 2021
It was basically just a `environment.systemPackages` synonym,
only GNOME used it, and it was stretching the responsibilities
of the flatpak module too far.

It also makes it cleaner to avoid installing the program
using GNOME module’s `excludePackages` option.

Partially reverts: NixOS#101516
Fixes: NixOS#110310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants