Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocksdb: 6.10.2 -> 6.12.7 #101559

Merged
merged 2 commits into from Oct 25, 2020
Merged

rocksdb: 6.10.2 -> 6.12.7 #101559

merged 2 commits into from Oct 25, 2020

Conversation

@basvandijk
Copy link
Member

@basvandijk basvandijk commented Oct 24, 2020

Motivation for this change

https://github.com/facebook/rocksdb/blob/v6.12.7/HISTORY.md#6127-2020-10-14

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@basvandijk
Copy link
Member Author

@basvandijk basvandijk commented Oct 24, 2020

@GrahamcOfBorg build rocksdb

@basvandijk
Copy link
Member Author

@basvandijk basvandijk commented Oct 24, 2020

@GrahamcOfBorg build rocksdb sortmerna

@basvandijk
Copy link
Member Author

@basvandijk basvandijk commented Oct 24, 2020

@GrahamcOfBorg build rocksdb

@basvandijk
Copy link
Member Author

@basvandijk basvandijk commented Oct 24, 2020

@GrahamcOfBorg build sortmerna

@basvandijk
Copy link
Member Author

@basvandijk basvandijk commented Oct 24, 2020

Result of nixpkgs-review pr 101559 1

1 package marked as broken and skipped:
  • bareos
4 packages failed to build:
  • ceph
  • ceph-client
  • libceph
  • samba4Full
4 packages built:
  • blockbook
  • rocksdb
  • rocksdb_lite
  • sortmerna

@basvandijk
Copy link
Member Author

@basvandijk basvandijk commented Oct 24, 2020

The failures reported by nixpkgs-review above are all due to ceph failing to build. This is not due to this PR since ceph is already failing on master.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Builds on darwin and NixOS.

@basvandijk basvandijk merged commit 67f5d7f into NixOS:master Oct 25, 2020
22 of 26 checks passed
@basvandijk basvandijk mentioned this pull request Nov 1, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants