Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kind: 0.8.1 -> 0.9.0 #101577

Merged
merged 1 commit into from Oct 25, 2020
Merged

kind: 0.8.1 -> 0.9.0 #101577

merged 1 commit into from Oct 25, 2020

Conversation

@jonafato
Copy link
Contributor

@jonafato jonafato commented Oct 24, 2020

Motivation for this change

kind has a new bugfix release. Changelog

This commit also enables fish completions, which were added to kind in 0.8.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@offlinehacker @rawkode

kind has a new bugfix release. [Changelog](https://github.com/kubernetes-sigs/kind/releases/tag/v0.9.0)

This commit also enables fish completions, which were added to kind in
0.8.0.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 24, 2020

Result of nixpkgs-review pr 101577 1

1 package built:
  • kind

Copy link
Member

@endocrimes endocrimes left a comment

I don't have fish installed so couldn't test those changes specifically, but verified kind itself.

@bhipple bhipple merged commit b37c198 into NixOS:master Oct 25, 2020
19 checks passed
@jonafato jonafato deleted the kind-0.9.0 branch Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants