Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox-bin: fix update.nix freezing #101624

Merged
merged 1 commit into from Oct 25, 2020
Merged

Conversation

@taku0
Copy link
Contributor

@taku0 taku0 commented Oct 25, 2020

For some reason, update.nix freeze at echo "$shasums". #98338 (comment)

This fix the issue but I don't know why.

cc: @andir, @stigtsp, @Atemu

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Mic92 Mic92 merged commit c8bccb0 into NixOS:master Oct 25, 2020
16 checks passed
@Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 25, 2020

good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants