Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aflplusplus: standardize description #101634

Merged
merged 1 commit into from Nov 24, 2020
Merged

Conversation

@siraben
Copy link
Member

@siraben siraben commented Oct 25, 2020

  • Remove package name from start
  • Remove period from end
Motivation for this change

To fit CONTRIBUTING.md.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@siraben siraben force-pushed the aflplusplus-period branch from ff63344 to 8aa3400 Oct 25, 2020
pkgs/tools/security/aflplusplus/default.nix Outdated Show resolved Hide resolved
@siraben siraben force-pushed the aflplusplus-period branch from 8aa3400 to 3eda2e5 Oct 25, 2020
@siraben siraben requested a review from danieldk Nov 19, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 23, 2020

Can you rebase this PR to make ofborg happy?

@siraben siraben force-pushed the aflplusplus-period branch from 3eda2e5 to 14e0198 Nov 23, 2020
@siraben
Copy link
Member Author

@siraben siraben commented Nov 23, 2020

Can you rebase this PR to make ofborg happy?

Done.

- Remove package name from start
- Remove period from end
@siraben siraben force-pushed the aflplusplus-period branch from 14e0198 to b6b2b2f Nov 24, 2020
@danieldk danieldk merged commit 9994738 into NixOS:master Nov 24, 2020
18 checks passed
@siraben siraben deleted the aflplusplus-period branch Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants