Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopls: don't build integration tests or documentation generator #101641

Merged
merged 1 commit into from Oct 28, 2020

Conversation

@lukegb
Copy link
Contributor

@lukegb lukegb commented Oct 25, 2020

Not only are these not used, but they also have super generic names,
which is confusing when they appear on the path, and possibly leads
to conflicts with other binaries.

Motivation for this change

The "gopls" package currently produces a directory containing three integration test binaries and a binary simply named "doc". The "doc" binary is particularly frustratating because it also conflicts with a similarly named binary in gotools.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Before:
$ nix path-info -f ./ -S gopls
/nix/store/373wla596ndqxygi0mr60q8wfid3y5bs-gopls-0.4.1	   62052208

After:
$ nix path-info -f ./ -S gopls
/nix/store/zb07swkmqckrk9jqzhrz9xvjpcpkfs0h-gopls-0.4.1	   53274680
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

I did a quick research and I think vimPlugins.vim-go which depends on gopls does not require those binaries.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2020

@lukegb Can you please rebase on master to fix borg eval?

Not only are these not used, but they also have super generic names,
which is confusing when they appear on the path, and possibly leads
to conflicts with other binaries.
@ofborg ofborg bot requested review from kalbasit, Mic92 and zimbatm Oct 28, 2020
@zimbatm zimbatm merged commit a30a084 into NixOS:master Oct 28, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
gopls, gopls.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
gopls, gopls.passthru.tests on x86_64-linux Success
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a91f4b"; rev="6a91f4bc9f5d7211552c8076f411f76f777a3ad7"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a91f4b"; rev="6a91f4bc9f5d7211552c8076f411f76f777a3ad7"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a91f4b"; rev="6a91f4bc9f5d7211552c8076f411f76f777a3ad7"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a91f4b"; rev="6a91f4bc9f5d7211552c8076f411f76f777a3ad7"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a91f4b"; rev="6a91f4bc9f5d7211552c8076f411f76f777a3ad7"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a91f4b"; rev="6a91f4bc9f5d7211552c8076f411f76f777a3ad7"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6a91f4b"; rev="6a91f4bc9f5d7211552c8076f411f76f777a3ad7"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants