Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rofi-calc: 1.8 -> 1.9 #101646

Merged
merged 1 commit into from Oct 26, 2020
Merged

rofi-calc: 1.8 -> 1.9 #101646

merged 1 commit into from Oct 26, 2020

Conversation

@luc65r
Copy link
Contributor

@luc65r luc65r commented Oct 25, 2020

Motivation for this change

Update rofi-calc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Can you remove platforms darwin? Rofi does not build/work on darwin either which makes this fail to build. See https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/misc/rofi/default.nix#L34

@Ma27 Ma27 merged commit 61fa498 into NixOS:master Oct 26, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants