Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geany: 1.36.0 -> 1.37.0 #101674

Merged
merged 1 commit into from Oct 25, 2020
Merged

geany: 1.36.0 -> 1.37.0 #101674

merged 1 commit into from Oct 25, 2020

Conversation

@frlan
Copy link
Contributor

@frlan frlan commented Oct 25, 2020

Motivation for this change

New upstream release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 25, 2020

platforms = platforms.all; can be removed. That is the default.

Can you update the commit message to use a lowercase g?

Also builds fine on darwin.

@frlan frlan force-pushed the Update/Geany/1.37.0 branch from e699ad5 to efdf7be Oct 25, 2020
@frlan
Copy link
Contributor Author

@frlan frlan commented Oct 25, 2020

@r-burns
Copy link
Contributor

@r-burns r-burns commented Oct 25, 2020

@SuperSandro2000 platforms.all is needed to build on hydra, #99995 (comment)

@frlan frlan force-pushed the Update/Geany/1.37.0 branch from efdf7be to b1b7551 Oct 25, 2020
@frlan
Copy link
Contributor Author

@frlan frlan commented Oct 25, 2020

Re-added it. If it's a default now it will not hurt anyway.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 25, 2020

Sorry about the wrong suggestion. I retraced a miss information from a while ago. r-burns is right.

@frlan
Copy link
Contributor Author

@frlan frlan commented Oct 25, 2020

@SuperSandro2000 It's ok with me -- nevermind ;)

@frlan frlan changed the title Geany: 1.36.0 -> 1.37.0 geany: 1.36.0 -> 1.37.0 Oct 25, 2020
Copy link
Contributor

@r-burns r-burns left a comment

WFM non-nixos linux

Copy link
Contributor

@jtojnar jtojnar left a comment

@jtojnar jtojnar merged commit 30da0b7 into NixOS:master Oct 25, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
geany, geany.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
geany, geany.passthru.tests on x86_64-linux Success
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1b7551"; rev="b1b7551cb05a29f6898b42242673eb2e2c37203c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1b7551"; rev="b1b7551cb05a29f6898b42242673eb2e2c37203c"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1b7551"; rev="b1b7551cb05a29f6898b42242673eb2e2c37203c"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1b7551"; rev="b1b7551cb05a29f6898b42242673eb2e2c37203c"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1b7551"; rev="b1b7551cb05a29f6898b42242673eb2e2c37203c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1b7551"; rev="b1b7551cb05a29f6898b42242673eb2e2c37203c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1b7551"; rev="b1b7551cb05a29f6898b42242673eb2e2c37203c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants