Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whalebird: init at 4.3.1 #101689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

whalebird: init at 4.3.1 #101689

wants to merge 1 commit into from

Conversation

@greydot
Copy link
Contributor

@greydot greydot commented Oct 25, 2020

Motivation for this change

Introduce Whalebird.

Things done

Added whalebird derivation for Linux x64.

Note that while it is an open source app, building it from source is nigh impossible due to Electron being weird :(

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@aanderse aanderse left a comment

I don't know anything about packaging electron apps, but I did notice two minor things you could fixup.

pkgs/applications/networking/whalebird/default.nix Outdated Show resolved Hide resolved
@greydot
Copy link
Contributor Author

@greydot greydot commented Oct 26, 2020

I don't know anything about packaging electron apps, but I did notice two minor things you could fixup.

Thank you! Fixed now.

@aanderse aanderse dismissed their stale review Oct 26, 2020

I'm not qualified to review Electron specific packages.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 101689 run on x86_64-linux 1

1 package built:
  • whalebird

@greydot greydot changed the title whalebird: init at 4.2.3 whalebird: init at 4.3.0 Nov 6, 2020
@greydot
Copy link
Contributor Author

@greydot greydot commented Nov 6, 2020

Updated to 4.3.0

};

in appimageTools.wrapType2 rec {
name = pname;
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 24, 2020

Suggested change
name = pname;
name = "${pname}-${version}";

Copy link
Contributor Author

@greydot greydot Dec 8, 2020

Done.

Copy link
Contributor Author

@greydot greydot Dec 8, 2020

Except this is a bad idea, because that is the name appimageTools uses for the program binary name. I'll revert this.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 24, 2020

Result of nixpkgs-review pr 101689 run on x86_64-linux 1

1 package built:
  • whalebird

@greydot greydot force-pushed the whalebird branch 2 times, most recently from 15ed53a to 82d4a8d Dec 8, 2020
@greydot greydot changed the title whalebird: init at 4.3.0 whalebird: init at 4.3.1 Dec 8, 2020
@stale
Copy link

@stale stale bot commented Jun 6, 2021

I marked this as stale due to inactivity. → More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants