Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kops_1_18: 1.18.1 -> 1.18.2 #101692

Merged
merged 1 commit into from Oct 25, 2020
Merged

kops_1_18: 1.18.1 -> 1.18.2 #101692

merged 1 commit into from Oct 25, 2020

Conversation

@kampka
Copy link
Contributor

@kampka kampka commented Oct 25, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested review from zimbatm and offlinehacker Oct 25, 2020
@zimbatm zimbatm merged commit b42b8c1 into NixOS:master Oct 25, 2020
19 checks passed
blaggacao added a commit to xoe-labs/nixpkgs that referenced this issue Oct 27, 2020
takagiy added a commit to takagiy/nixpkgs that referenced this issue Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants