Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minishift: 1.34.2 -> 1.34.3 #101698

Merged
merged 1 commit into from Nov 26, 2020
Merged

Conversation

@r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Oct 25, 2020

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/minishift/minishift/releases.

meta.description for minishift is: "Run OpenShift locally"

meta.homepage for minishift is: "https://github.com/minishift/minishift"

meta.changelog for minishift is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
minishift
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/bn3c889dyfg3fvqjq4gk74qh1ipvadnl-minishift-1.34.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A minishift https://github.com/r-ryantm/nixpkgs/archive/8dac52cd1c8d308b8a428d885e7cf50ec2494262.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/bn3c889dyfg3fvqjq4gk74qh1ipvadnl-minishift-1.34.3
ls -la /nix/store/bn3c889dyfg3fvqjq4gk74qh1ipvadnl-minishift-1.34.3/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package built:
  • minishift

Maintainer pings

cc @fpletz @vdemeester for testing.

Copy link
Member

@vdemeester vdemeester left a comment

LGTM

Copy link
Member

@ryantm ryantm left a comment

The centos iso version doesn't match the makefile. @vdemeester

@vdemeester
Copy link
Member

@vdemeester vdemeester commented Oct 26, 2020

@ryantm ah crap, I forgot about that 😓

@SuperSandro2000 SuperSandro2000 force-pushed the auto-update/minishift branch from 8dac52c to 02885ae Nov 26, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 101698 run on x86_64-linux 1

1 package built:
  • minishift

@ofborg ofborg bot requested a review from vdemeester Nov 26, 2020
@SuperSandro2000 SuperSandro2000 merged commit 6fffc43 into NixOS:master Nov 26, 2020
19 of 20 checks passed
19 of 20 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
minishift, minishift.passthru.tests on x86_64-darwin
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="02885ae"; rev="02885ae8e207c5c4c1d2f3e7ac02f7e72c99d13e"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="02885ae"; rev="02885ae8e207c5c4c1d2f3e7ac02f7e72c99d13e"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="02885ae"; rev="02885ae8e207c5c4c1d2f3e7ac02f7e72c99d13e"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="02885ae"; rev="02885ae8e207c5c4c1d2f3e7ac02f7e72c99d13e"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="02885ae"; rev="02885ae8e207c5c4c1d2f3e7ac02f7e72c99d13e"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="02885ae"; rev="02885ae8e207c5c4c1d2f3e7ac02f7e72c99d13e"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="02885ae"; rev="02885ae8e207c5c4c1d2f3e7ac02f7e72c99d13e"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
minishift, minishift.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
minishift, minishift.passthru.tests on x86_64-linux Success
Details
@r-ryantm r-ryantm deleted the auto-update/minishift branch Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants