Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvm: init at 0.7.0 #101728

Merged
merged 1 commit into from Dec 8, 2020
Merged

tvm: init at 0.7.0 #101728

merged 1 commit into from Dec 8, 2020

Conversation

@adelbertc
Copy link
Contributor

@adelbertc adelbertc commented Oct 26, 2020

Motivation for this change

New package: TVM, An End to End Deep Learning Compiler Stack for CPUs, GPUs and accelerators.

cc @imalsogreg @tkonolige

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux) <-- does this work on Darwin ATM? It didn't last time I checked.
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) <-- None, shared headers and library only
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Result of a Nix build
$ ls -R result
result:
include  lib

result/include:
tvm

result/include/tvm:
runtime

result/include/tvm/runtime:
c_backend_api.h  container.h  data_type.h   memory.h  module.h	 object.h	registry.h    threading_backend.h
c_runtime_api.h  crt	      device_api.h  micro     ndarray.h  packed_func.h	serializer.h  vm

result/include/tvm/runtime/crt:
crt.h  error_codes.h  func_registry.h  graph_runtime.h	logging.h  memory.h  module.h  packed_func.h  platform.h  rpc_common  utvm_rpc_server.h

result/include/tvm/runtime/crt/rpc_common:
frame_buffer.h	framing.h  session.h  write_stream.h

result/include/tvm/runtime/micro:
standalone

result/include/tvm/runtime/micro/standalone:
utvm_runtime.h

result/include/tvm/runtime/vm:
bytecode.h  executable.h  memory_manager.h  vm.h

result/lib:
libtvm.dylib  libtvm_runtime.dylib
Copy link
Contributor

@r-burns r-burns left a comment

Builds on darwin. Some quick suggestions but otherwise LGTM. Oh, and remember to fixup your commits before merging.

pkgs/development/compilers/tvm/default.nix Show resolved Hide resolved
pkgs/development/compilers/tvm/default.nix Outdated Show resolved Hide resolved
@adelbertc
Copy link
Contributor Author

@adelbertc adelbertc commented Oct 26, 2020

@r-burns Feedback addresses, commits fixed up :-)

@imalsogreg
Copy link
Contributor

@imalsogreg imalsogreg commented Oct 26, 2020

This looks good to me! Builds fine on my linux box.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 27, 2020

Run on darwin:

Result of nixpkgs-review pr 101728 1

1 package built:
  • tvm

@adelbertc adelbertc force-pushed the init-tvm branch 2 times, most recently from 228004a to 85fe30e Oct 27, 2020
@adelbertc
Copy link
Contributor Author

@adelbertc adelbertc commented Oct 29, 2020

@sikmir Are you able to merge this?

@sikmir
Copy link
Member

@sikmir sikmir commented Oct 29, 2020

@sikmir Are you able to merge this?

I'm only maintainer, not a commiter.

pkgs/development/compilers/tvm/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/tvm/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 101728 run on x86_64-linux 1

1 package built:
  • tvm

@adelbertc
Copy link
Contributor Author

@adelbertc adelbertc commented Nov 26, 2020

@SuperSandro2000 Good for merge? :D

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

@adelbertc please squash the commit. After that it can be merged.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 101728 run on x86_64-darwin 1

1 package built:
  • tvm

@adelbertc
Copy link
Contributor Author

@adelbertc adelbertc commented Nov 27, 2020

@adelbertc
Copy link
Contributor Author

@adelbertc adelbertc commented Dec 5, 2020

@SuperSandro2000 Any love? :D

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 7, 2020

Result of nixpkgs-review pr 101728 1 on darwin

1 package built:
  • tvm

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 8, 2020

Result of nixpkgs-review pr 101728 run on x86_64-linux 1

1 package built:
  • tvm

@SuperSandro2000 SuperSandro2000 merged commit 407469c into NixOS:master Dec 8, 2020
19 checks passed
@adelbertc adelbertc deleted the init-tvm branch Dec 8, 2020
@adelbertc
Copy link
Contributor Author

@adelbertc adelbertc commented Dec 8, 2020

@SuperSandro2000 Thank you!! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants