Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] treewide: mark broken for 20.09 #101736

Merged
merged 4 commits into from Oct 27, 2020

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 26, 2020

Motivation for this change

using git hub file changes to make sure the diff looks good

Fixes #100111

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer jonringer force-pushed the mark-broken-20.09 branch from e76e4ed to 3f8de00 Oct 26, 2020
@jonringer jonringer changed the title treewide: intial mark broken for 20.09 [20.09] treewide: intial mark broken for 20.09 Oct 26, 2020
@ofborg ofborg bot removed the 6.topic: haskell label Oct 26, 2020
@cole-h
Copy link
Member

@cole-h cole-h commented Oct 26, 2020

cc issue #100111

@jonringer jonringer requested a review from ttuegel as a code owner Oct 26, 2020
@worldofpeace worldofpeace added this to the 20.09 milestone Oct 26, 2020
@worldofpeace worldofpeace added this to In progress in 20.09 Blockers via automation Oct 26, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 26, 2020

cc @worldofpeace should this close ZHF. This seems like the "capstone" for stabilization

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 26, 2020

@jonringer Yes. But people can still contribute fixes to unbreak things. Be sure to comment there as well.

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 26, 2020

@jonringer Yes. But people can still contribute fixes to unbreak things. Be sure to comment there as well.

Of course, but it would be weird to have the ZHF item open indefinitely. I'll just change the original post to mention that the backport commit may need to remove "broken = true;"

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 26, 2020

Of course, but it would be weird to have the ZHF item open indefinitely.

I was agreeing with "yes".

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 26, 2020

Not sure why i read that as a rebuttable

I guess I violently agree as well

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 26, 2020

all that remains are the linux modules:

linuxPackages_5_8.batman_adv
linuxPackages_5_8.chipsec
linuxPackages_5_8.exfat-nofuse
linuxPackages_5_8.mxu11x0
linuxPackages_5_8.ndiswrapper
linuxPackages_5_8.netatop
linuxPackages_5_8.nvidiabl
linuxPackages_5_8.openafs_1_8
linuxPackages_5_8.r8168
linuxPackages_5_8.rtl8814au
linuxPackages_5_8.rtl8821au
linuxPackages_5_8.rtl88xxau-aircrack
linuxPackages_5_8.rtlwifi_new
linuxPackages_5_9.anbox
linuxPackages_5_9.batman_adv
linuxPackages_5_9.chipsec
linuxPackages_5_9.dpdk
linuxPackages_5_9.ena
linuxPackages_5_9.evdi
linuxPackages_5_9.exfat-nofuse
linuxPackages_5_9.mxu11x0
linuxPackages_5_9.ndiswrapper
linuxPackages_5_9.netatop
linuxPackages_5_9.nvidiabl
linuxPackages_5_9.openafs_1_8
linuxPackages_5_9.r8168
linuxPackages_5_9.rtl8814au
linuxPackages_5_9.rtl8821au
linuxPackages_5_9.rtl88xxau-aircrack
linuxPackages_5_9.rtlwifi_new
linuxPackages_5_9.virtualbox
linuxPackages_5_9.virtualboxGuestAdditions
linuxPackages_5_9.zfs
linuxPackages_5_9.zfsStable
linuxPackages_hardened.mxu11x0
linuxPackages_hardened.ndiswrapper
linuxPackages_hardened.openafs_1_8
linuxPackages_hardened.r8168
linuxPackages_hardened.rtl8814au
linuxPackages_hardened.rtl8821au
linuxPackages_hardened.rtlwifi_new
linuxPackages_latest-libre.anbox
linuxPackages_latest-libre.batman_adv
linuxPackages_latest-libre.chipsec
linuxPackages_latest-libre.exfat-nofuse
linuxPackages_latest-libre.mxu11x0
linuxPackages_latest-libre.ndiswrapper
linuxPackages_latest-libre.netatop
linuxPackages_latest-libre.nvidiabl
linuxPackages_latest-libre.openafs_1_8
linuxPackages_latest-libre.r8168
linuxPackages_latest-libre.rtl8814au
linuxPackages_latest-libre.rtl8821au
linuxPackages_latest-libre.rtl88xxau-aircrack
linuxPackages_latest-libre.rtlwifi_new
linuxPackages_latest.anbox
linuxPackages_latest.batman_adv
linuxPackages_latest.chipsec
linuxPackages_latest.exfat-nofuse
linuxPackages_latest.mxu11x0
linuxPackages_latest.ndiswrapper
linuxPackages_latest.netatop
linuxPackages_latest.nvidiabl
linuxPackages_latest.openafs_1_8
linuxPackages_latest.r8168
linuxPackages_latest.rtl8814au
linuxPackages_latest.rtl8821au
linuxPackages_latest.rtl88xxau-aircrack
linuxPackages_latest.rtlwifi_new
linuxPackages_latest_hardened.anbox
linuxPackages_latest_hardened.batman_adv
linuxPackages_latest_hardened.chipsec
linuxPackages_latest_hardened.exfat-nofuse
linuxPackages_latest_hardened.mxu11x0
linuxPackages_latest_hardened.ndiswrapper
linuxPackages_latest_hardened.netatop
linuxPackages_latest_hardened.nvidiabl
linuxPackages_latest_hardened.openafs_1_8
linuxPackages_latest_hardened.r8168
linuxPackages_latest_hardened.rtl8814au
linuxPackages_latest_hardened.rtl8821au
linuxPackages_latest_hardened.rtl88xxau-aircrack
linuxPackages_latest_hardened.rtlwifi_new
linuxPackages_latest_xen_dom0.anbox
linuxPackages_latest_xen_dom0.batman_adv
linuxPackages_latest_xen_dom0.chipsec
linuxPackages_latest_xen_dom0.exfat-nofuse
linuxPackages_latest_xen_dom0.mxu11x0
linuxPackages_latest_xen_dom0.ndiswrapper
linuxPackages_latest_xen_dom0.netatop
linuxPackages_latest_xen_dom0.nvidiabl
linuxPackages_latest_xen_dom0.openafs_1_8
linuxPackages_latest_xen_dom0.r8168
linuxPackages_latest_xen_dom0.rtl8814au
linuxPackages_latest_xen_dom0.rtl8821au
linuxPackages_latest_xen_dom0.rtl88xxau-aircrack
linuxPackages_latest_xen_dom0.rtlwifi_new
linuxPackages_latest_xen_dom0_hardened.anbox
linuxPackages_latest_xen_dom0_hardened.batman_adv
linuxPackages_latest_xen_dom0_hardened.chipsec
linuxPackages_latest_xen_dom0_hardened.exfat-nofuse
linuxPackages_latest_xen_dom0_hardened.mxu11x0
linuxPackages_latest_xen_dom0_hardened.ndiswrapper
linuxPackages_latest_xen_dom0_hardened.netatop
linuxPackages_latest_xen_dom0_hardened.nvidiabl
linuxPackages_latest_xen_dom0_hardened.openafs_1_8
linuxPackages_latest_xen_dom0_hardened.r8168
linuxPackages_latest_xen_dom0_hardened.rtl8814au
linuxPackages_latest_xen_dom0_hardened.rtl8821au
linuxPackages_latest_xen_dom0_hardened.rtl88xxau-aircrack
linuxPackages_latest_xen_dom0_hardened.rtlwifi_new
linuxPackages_testing_bcachefs.ndiswrapper
linuxPackages_testing_bcachefs.rtl8814au
linuxPackages_testing_bcachefs.rtl8821au
linuxPackages_xen_dom0.mxu11x0
linuxPackages_xen_dom0.ndiswrapper
linuxPackages_xen_dom0.r8168
linuxPackages_xen_dom0.rtl8814au
linuxPackages_xen_dom0.rtl8821au
linuxPackages_xen_dom0.rtlwifi_new
linuxPackages_xen_dom0_hardened.mxu11x0
linuxPackages_xen_dom0_hardened.ndiswrapper
linuxPackages_xen_dom0_hardened.openafs_1_8
linuxPackages_xen_dom0_hardened.r8168
linuxPackages_xen_dom0_hardened.rtl8814au
linuxPackages_xen_dom0_hardened.rtl8821au
linuxPackages_xen_dom0_hardened.rtlwifi_new
linuxPackages_zen.anbox
linuxPackages_zen.batman_adv
linuxPackages_zen.chipsec
linuxPackages_zen.exfat-nofuse
linuxPackages_zen.mxu11x0
linuxPackages_zen.ndiswrapper
linuxPackages_zen.netatop
linuxPackages_zen.nvidiabl
linuxPackages_zen.openafs_1_8
linuxPackages_zen.r8168
linuxPackages_zen.rtl8814au
linuxPackages_zen.rtl8821au
linuxPackages_zen.rtl88xxau-aircrack
linuxPackages_zen.rtlwifi_new

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 26, 2020

I will probably tackle the linux modules in a different PR, as we don't really have a good way (that I'm aware of) to determine the "flavor" of the kernel (e.g. libre, zen, xen, hardened, etc.)

@jonringer jonringer moved this from In progress to Review in progress in 20.09 Blockers Oct 27, 2020
@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 27, 2020

That's an awful lot of modules.

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 27, 2020

I hope for people's hardware they can't rebuild switch because a module for the stable kernel doesn't build. Obviously something to handle after release.

@jonringer jonringer force-pushed the mark-broken-20.09 branch from 97685ed to b031bb9 Oct 27, 2020
@jonringer jonringer changed the title [20.09] treewide: intial mark broken for 20.09 [20.09] treewide: mark broken for 20.09 Oct 27, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 27, 2020

https://github.com/NixOS/nixpkgs/pull/101736
2 packages marked as broken and skipped:
python37Packages.pythonmagick python38Packages.pythonmagick

4 packages built:
python27Packages.locustio python27Packages.msal-extensions python27Packages.python-axolotl python37Packages.sphinxcontrib-spelling

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 27, 2020

going to "forward port" some of the python fixes in a different PR

@jonringer jonringer merged commit 9a0b14b into NixOS:release-20.09 Oct 27, 2020
16 checks passed
20.09 Blockers automation moved this from Review in progress to Done Oct 27, 2020
@jonringer jonringer deleted the mark-broken-20.09 branch Oct 27, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 29, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/upgrade-20-03-to-20-09-failes-due-to-brocken-libguestfs-1-40-2/9721/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants