Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseaudio: hsphfpd implementation #101787

Closed
wants to merge 9 commits into from
Closed

Conversation

@eadwu
Copy link
Member

@eadwu eadwu commented Oct 26, 2020

Motivation for this change

Only meant as a reference implementation for testing

Closes: #87910

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@@ -26,6 +26,11 @@ in stdenv.mkDerivation rec {
sha256 = "1p2ncvjz6alr9n3l5wvq2arqgc7xjs6dqyar1l9jp0z8cfgapkb8";
};

patches = [
# ./config-after-first-failure.patch
Copy link
Member

@SuperSandro2000 SuperSandro2000 Oct 26, 2020

Is this a misstake?

Copy link
Member Author

@eadwu eadwu Oct 26, 2020

Read the description, it's a reference implementation, as well as the root MR request, https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/288

I'm not planning on ever getting this into shape, I can't tell any functionality difference between this over the normal pulseaudio, actually causes more instability for me.

But some people showed interest in it, thus why I created the draft.

Copy link
Contributor

@jtojnar jtojnar Oct 28, 2020

I will try to work on this, if I find time. One benefit would be having support for absolute volume levels, especially in conjunction with !239. Another would be bluetooth battery indicator but that still needs upower support.

@eadwu eadwu force-pushed the pulseaudio/hsphfpd branch 2 times, most recently from a2cd3ed to 09f9e30 Oct 29, 2020
@eadwu eadwu force-pushed the pulseaudio/hsphfpd branch from 03a2eca to 1255466 Oct 29, 2020
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 30, 2020

@eadwu Enabling debug mode should be something like the following options:

hardware.pulseaudio.daemon.logLevel = "debug";
systemd.services.bluetooth.serviceConfig.ExecStart = [ "" "${hardware.bluetooth.package}/libexec/bluetooth/bluetoothd -d" ];

No special reason, it's just since Pipewire also integrates with hsphfpd
@eadwu eadwu force-pushed the pulseaudio/hsphfpd branch from 90712ea to 862dab9 Oct 30, 2020
@gebner
Copy link
Member

@gebner gebner commented Nov 9, 2020

I believe we can get this in a mergable state by adding a second duplicate pulseaudio derivation for the hsphfpd-patched version. Then we don't need to modify the default pulseaudio and don't cause any mass rebuilds. I'm currently running this and it seems to work fine.

@eadwu Is it ok if I take over the PR and make changes along those lines? We want to get the hsphfpd part merged anyhow since apparently pipewire can use it as well now.

@eadwu
Copy link
Member Author

@eadwu eadwu commented Nov 9, 2020

Works fine for me.

The reason why I used meson in the first place was because the autotools build was broken on my end.

@eadwu eadwu closed this Nov 9, 2020
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 9, 2020

Hopefully, Pulseaudio 14 will be released before the end of the year and we will be able to switch to Meson in the main derivation.

https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/milestones/1

@gebner gebner mentioned this pull request Nov 9, 2020
10 tasks
@gebner
Copy link
Member

@gebner gebner commented Nov 9, 2020

New PR: #103225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants