Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xarchiver: fix running #101788

Merged
merged 1 commit into from Dec 11, 2020
Merged

xarchiver: fix running #101788

merged 1 commit into from Dec 11, 2020

Conversation

@tex
Copy link
Contributor

@tex tex commented Oct 26, 2020

Motivation for this change

To make xarchiver usable. For example this change is needed so it can open an archive. Otherwise it crashes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@tex tex force-pushed the tex/xarchiver branch from 2ab1da7 to c485356 Oct 29, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 101788 run on x86_64-linux 1

1 package built:
  • xarchiver

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 101788 run on x86_64-darwin 1

1 package built:
  • xarchiver

@tex
Copy link
Contributor Author

@tex tex commented Dec 3, 2020

What else is needed to get this merged?

@SuperSandro2000 SuperSandro2000 merged commit 1734577 into NixOS:master Dec 11, 2020
17 checks passed
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 11, 2020

What else is needed to get this merged?

More time in the day. I can't keep up with the PRs I commented.

@tex
Copy link
Contributor Author

@tex tex commented Dec 11, 2020

Great! I would need more time in the day too :)
How can one get merge power for nixpkgs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants