Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemdMinimal: build without glib #101792

Merged
merged 1 commit into from Oct 27, 2020
Merged

Conversation

@flokli
Copy link
Contributor

@flokli flokli commented Oct 26, 2020

This takes glib (and by this, gtk-doc) out of systemdMinimal's build
closure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This takes glib (and by this, gtk-doc) out of systemdMinimal's build
closure.
@andir andir merged commit 5d03fe6 into NixOS:staging Oct 27, 2020
19 of 20 checks passed
systemd automation moved this from To Do to Done Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
systemd
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants