Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxima: remove 5.41.0 #101793

Merged
merged 1 commit into from Oct 27, 2020
Merged

maxima: remove 5.41.0 #101793

merged 1 commit into from Oct 27, 2020

Conversation

@omasanori
Copy link
Contributor

@omasanori omasanori commented Oct 26, 2020

Motivation for this change

This change now-unused Maxima 5.41 from nixpkgs. It had been kept for SageMath but now it uses the default Maxima with ECL.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
It had been kept for SageMath, but it uses the default version nowadays
and this version is not referenced in nixpkgs.

Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@omasanori
Copy link
Contributor Author

@omasanori omasanori commented Oct 26, 2020

Any thoughts, @timokau?

Update: timokau on IRC:

If you can make it work without that version of maxima, feel free to remove it.

I think it should be possible, as SageMath 9.2 bundles Maxima 5.44.0 + ECL 20.4.24.

Copy link
Contributor

@wamserma wamserma left a comment

LGTM. There is nothing left in nixpkgs with an obvious reference to this and nixpkgs-review came out clean.

Still needs the "8.has: clean-up" label.

Copy link
Member

@timokau timokau left a comment

Ah, now I understand what you meant. I must have forgotten to remove that file when removing all references to it. Thank you!

@timokau timokau merged commit 39e62d5 into NixOS:master Oct 27, 2020
18 checks passed
18 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="40fb3ed"; rev="40fb3ed6dc4c817e0416ae7c562aa6efff3fe241"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="40fb3ed"; rev="40fb3ed6dc4c817e0416ae7c562aa6efff3fe241"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="40fb3ed"; rev="40fb3ed6dc4c817e0416ae7c562aa6efff3fe241"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="40fb3ed"; rev="40fb3ed6dc4c817e0416ae7c562aa6efff3fe241"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="40fb3ed"; rev="40fb3ed6dc4c817e0416ae7c562aa6efff3fe241"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="40fb3ed"; rev="40fb3ed6dc4c817e0416ae7c562aa6efff3fe241"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="40fb3ed"; rev="40fb3ed6dc4c817e0416ae7c562aa6efff3fe241"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
maxima, maxima.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
maxima, maxima.passthru.tests on x86_64-linux Success
Details
@omasanori omasanori deleted the maxima/remove-5.41 branch Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants