Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilp2: init at 1.18 #101796

Merged
merged 7 commits into from Jan 25, 2021
Merged

tilp2: init at 1.18 #101796

merged 7 commits into from Jan 25, 2021

Conversation

@luc65r
Copy link
Contributor

@luc65r luc65r commented Oct 26, 2020

Motivation for this change

Close #76098

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Oct 26, 2020

@siraben could you check if tilem still works?

@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Oct 26, 2020

I still have some problems with udev rules, as I need to lauch tilp as root: libusb couldn't open USB device /dev/bus/usb/001/007: Permission denied.
idVendor and idProduct are right.
Do I need to restart udev somehow?

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Build on darwin:

Result of nixpkgs-review pr 101796 1

2 packages failed to build:
  • gfm
  • tilp2
5 packages built:
  • libticables2
  • libticalcs2
  • libticonv
  • libtifiles2
  • tilem
builder for '/nix/store/ynmg6ysnlj0bi7z5bs4k0r8n3hbl26da-gfm-1.08.tar.bz2.drv'
failed with exit code 1; last 10 log lines:
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0                                                                                                              curl: (22) The requested URL returned error: 404 Not Found
trying https://kent.dl.sourceforge.net/sourceforge/gfm/gfm-1.08.tar.bz2
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0   300    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
error: cannot download gfm-1.08.tar.bz2 from any mirror
cannot build derivation '/nix/store/aarinffrgifh34baab8l8sfa0kfai5kp-gfm-1.08.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3rckmylybwxmc1am737f2hig5vh4sggc-tilp2-1.18.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pnvy2w07j67vjiyc5dgrwj3zp2lsacdx-env.drv': 2 dependencies couldn't be built

pkgs/applications/science/math/gfm/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/math/tilp2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libticables2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libticalcs2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libtifiles2/default.nix Outdated Show resolved Hide resolved
@luc65r luc65r force-pushed the pkg/tilp2 branch 2 times, most recently from 8e9a668 to b6dcbf8 Oct 27, 2020
@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Oct 27, 2020

@SuperSandro2000 Sorry, wrong link, I should have deleted the source in /nix/store to test it.
It should work now

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 27, 2020

Run on darwin:

Result of nixpkgs-review pr 101796 1

7 packages built:
  • gfm
  • libticables2
  • libticalcs2
  • libticonv
  • libtifiles2
  • tilem
  • tilp2

@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Oct 27, 2020

value is a set while a list was expected at libticalcs2/default.nix:47:33
Why does this line fail? platforms = with platforms; linux ++ darwin;
There is the same line in every other file!
I tested reverting this line on this file to platforms = platforms.linux ++ platforms.darwin;, and everything works!
WTF????

Firstly, it means the same thing.
Secondly, there are these with platforms; on every other file, and they work.

Either I'm blind or this is a bug with nix.

@sikmir
Copy link
Member

@sikmir sikmir commented Oct 27, 2020

Either I'm blind or this is a bug with nix.

No magic, you have darwin parameter on line 12.
To fix problem, use inherit (darwin) libobjc in all-packages.nix.

@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Oct 27, 2020

I guess I'm blind then...

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 27, 2020

Run on darwin:

Result of nixpkgs-review pr 101796 1

7 packages built:
  • gfm
  • libticables2
  • libticalcs2
  • libticonv
  • libtifiles2
  • tilem
  • tilp2

Copy link
Member

@mkg20001 mkg20001 left a comment

nitpicks

pkgs/applications/science/math/gfm/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/math/gfm/default.nix Outdated Show resolved Hide resolved
];

buildInputs = [
gnome2.gtk
Copy link
Member

@mkg20001 mkg20001 Nov 2, 2020

gtk2 or gtk3?

Copy link
Member

@mkg20001 mkg20001 Nov 2, 2020

does this possibly need wrapGAppsHook (does this have an UI and does that ui work?)

Copy link
Contributor Author

@luc65r luc65r Nov 3, 2020

It needs gtk2: checking for gtk+-2.0 >= 2.6.0.
It has an UI, and it does work, so I guess it doesn't need wrapGAppsHook

Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 23, 2021

Is gtk2 and gnome2.gtk the same packages?

Copy link
Contributor Author

@luc65r luc65r Jan 24, 2021

Yes, they are the same package.
In pkgs/desktops/gnome-2/default.nix:

  gtk = pkgs.gtk2;

Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 24, 2021

Then I would prefer using gtk2.

pkgs/applications/science/math/tilp2/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/math/tilp2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libticonv/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libticonv/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libtifiles2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libtifiles2/default.nix Outdated Show resolved Hide resolved
};

config = mkIf cfg.enable {
services.udev.packages = [
Copy link
Member

@siraben siraben Nov 3, 2020

How come it has to be a NixOS module?

Copy link
Contributor Author

@luc65r luc65r Nov 3, 2020

We can't enable udev rules any other way, can we?

@siraben
Copy link
Member

@siraben siraben commented Nov 22, 2020

Result of nixpkgs-review pr 101796 1

7 packages built:
  • gfm
  • libticables2
  • libticalcs2
  • libticonv
  • libtifiles2
  • tilem
  • tilp2

@siraben
Copy link
Member

@siraben siraben commented Jan 23, 2021

@luc65r please resolve the merge conflict.

pkgs/applications/science/math/gfm/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/math/tilp2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libticables2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libticalcs2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libticalcs2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libticalcs2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libtifiles2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libticonv/default.nix Outdated Show resolved Hide resolved
];

buildInputs = [
gnome2.gtk
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 23, 2021

Is gtk2 and gnome2.gtk the same packages?

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 23, 2021

@luc65r please fix the eval error.

@ofborg ofborg bot requested a review from siraben Jan 24, 2021
Copy link
Member

@siraben siraben left a comment

LGTM. Thanks for doing this.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 24, 2021

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 101796 run on x86_64-darwin 1

7 packages built:
  • gfm
  • libticables2
  • libticalcs2
  • libticonv
  • libtifiles2
  • tilem
  • tilp2

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 24, 2021

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 101796 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
7 packages built:
  • gfm
  • libticables2
  • libticalcs2
  • libticonv
  • libtifiles2
  • tilem
  • tilp2

@SuperSandro2000 SuperSandro2000 merged commit a36bf6f into NixOS:master Jan 25, 2021
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants