Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minetime: 1.7.3 -> 1.8.10 #101797

Merged
merged 1 commit into from Nov 26, 2020
Merged

minetime: 1.7.3 -> 1.8.10 #101797

merged 1 commit into from Nov 26, 2020

Conversation

@cheriimoya
Copy link
Contributor

@cheriimoya cheriimoya commented Oct 26, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124

@ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 27, 2020

This only gives me a blank screen? Does it work for you?

@cheriimoya
Copy link
Contributor Author

@cheriimoya cheriimoya commented Oct 28, 2020

true, i accidentally ran the wrong version of minetime. from my nixpkgs, not the branch

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 101797 run on x86_64-linux 1

1 package built:
  • minetime

@SuperSandro2000 SuperSandro2000 merged commit 02fa320 into NixOS:master Nov 26, 2020
19 checks passed
@ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 26, 2020

??? does this work now?

@ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 27, 2020

@SuperSandro2000 are you sure this doesn't just show a white screen?

@cheriimoya cheriimoya deleted the minetime branch Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants