Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpaper: 1.1.24 -> 1.1.28 #101798

Merged
merged 1 commit into from Nov 18, 2020
Merged

libpaper: 1.1.24 -> 1.1.28 #101798

merged 1 commit into from Nov 18, 2020

Conversation

@bobvanderlinden
Copy link
Contributor

@bobvanderlinden bobvanderlinden commented Oct 26, 2020

Motivation for this change

debian testing is on 1.1.28.

It seems pkgs.ted is failing to compile. I thought this might have something to do with it. My laptop isn't that fast, so ted is still building locally, but it seems to be further along than it did before this change. If ted builds successfully, this change needs to be part of 20.09: #97479

Build of ted is still failing.

I tested this PR by building ted:

nix-build -A pkgs.ted
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@FRidh FRidh changed the base branch from master to staging Nov 18, 2020
@FRidh FRidh merged commit ceb3fde into NixOS:staging Nov 18, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants