Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndpi 2.8 -> 3.4 #101800

Merged
merged 1 commit into from Nov 25, 2020
Merged

ndpi 2.8 -> 3.4 #101800

merged 1 commit into from Nov 25, 2020

Conversation

@cheriimoya
Copy link
Contributor

@cheriimoya cheriimoya commented Oct 26, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124

@cheriimoya
Copy link
Contributor Author

@cheriimoya cheriimoya commented Oct 26, 2020

seems like this will close #90909 and all cves of #92860 except the last?

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Builds on darwin.

ajs124
ajs124 approved these changes Oct 27, 2020
Copy link
Member

@ajs124 ajs124 left a comment

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Result of nixpkgs-review pr 101800 run on x86_64-linux 1

1 package built:
  • ndpi

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Result of nixpkgs-review pr 101800 run on x86_64-darwin 1

1 package built:
  • ndpi

@SuperSandro2000 SuperSandro2000 merged commit 5d6004a into NixOS:master Nov 25, 2020
19 checks passed
@cheriimoya cheriimoya deleted the ndpi branch Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants