Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.py-multihash: 0.2.3 -> 1.0.0 #101801

Merged
merged 1 commit into from Nov 11, 2020

Conversation

@IvarWithoutBones
Copy link
Contributor

@IvarWithoutBones IvarWithoutBones commented Oct 26, 2020

Motivation for this change

Saw this failing on hydra, and decided to fix it.

the postPatch phase should be removed upon the next release, as explained in the comment.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Build on darwin:

Result of nixpkgs-review pr 101801 1

2 packages built:
  • python37Packages.py-multihash
  • python38Packages.py-multihash

Copy link
Contributor

@Luflosi Luflosi left a comment

LGTM

@IvarWithoutBones IvarWithoutBones force-pushed the fix-multihash branch 2 times, most recently from 3d14b67 to 0a05a32 Nov 11, 2020
@IvarWithoutBones IvarWithoutBones changed the title pythonPackages.py-multihash: fix build pythonPackages.py-multihash: 0.2.3 -> 1.0.0 Nov 11, 2020
@IvarWithoutBones IvarWithoutBones requested a review from mweinelt Nov 11, 2020
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 11, 2020

Result of nixpkgs-review pr 101801 1

2 packages built:
  • python37Packages.py-multihash
  • python38Packages.py-multihash

@mweinelt mweinelt merged commit 1da7e9e into NixOS:master Nov 11, 2020
2 of 4 checks passed
@IvarWithoutBones IvarWithoutBones deleted the fix-multihash branch Nov 11, 2020
Luflosi added a commit to Luflosi/nixpkgs that referenced this issue Feb 8, 2021
This was marked broken in NixOS#101636, which was merged into the staging branch. Later, the package was updated and fixed in NixOS#101801. When the staging branch was then merged into master, the package was marked as broken while actually being fixed.
beardhatcode added a commit to beardhatcode/nixpkgs that referenced this issue Feb 13, 2021
This was marked broken in NixOS#101636, which was merged into the staging branch. Later, the package was updated and fixed in NixOS#101801. When the staging branch was then merged into master, the package was marked as broken while actually being fixed.
LeUlukai added a commit to LeUlukai/nixpkgs that referenced this issue Feb 22, 2021
This was marked broken in NixOS#101636, which was merged into the staging branch. Later, the package was updated and fixed in NixOS#101801. When the staging branch was then merged into master, the package was marked as broken while actually being fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants