Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add 'how to request merging rights' #101806

Merged
merged 1 commit into from Dec 1, 2020
Merged

docs: Add 'how to request merging rights' #101806

merged 1 commit into from Dec 1, 2020

Conversation

@unode
Copy link
Member

@unode unode commented Oct 26, 2020

Linked also to the GitHub issue on how to become a committer

Motivation for this change

While looking for this information myself, I bumped into the TODO in the manual.
@cole-h provided the missing answer and the link to #50105

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
</para>
<orderedlist>
<listitem>
<para>Be active and well-known in the community</para>
Copy link
Member

@cole-h cole-h Oct 26, 2020

Note that these are not officially accepted terms -- those are just what I, personally, would use to decide if I was the one in power.

Copy link
Member Author

@unode unode Oct 26, 2020

Fair. "well-known" isn't exactly quantifiable but it read better than that TODO...

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 26, 2020

Errmm, this makes me sad. Because it's the unsavory truth that I'm too proud to put "on paper". Still to vague to actually be a "how to" though. Currently it really is just that thread.

@unode
Copy link
Member Author

@unode unode commented Oct 26, 2020

So... scrap the numbered list and keep the link to the GitHub issue and original TODO?

@unode
Copy link
Member Author

@unode unode commented Oct 26, 2020

I feel like that TODO is a bit damaging. Can I perhaps ping some of the folks in the linked issue?

Not looking for a verdict but more of a guideline. I believe new members to the community might seek the same.

At a personal level, while I don't think I qualify just yet I'd like be able to transform this guideline into some kind of milestone I could aim at.

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 26, 2020

I feel like that TODO is a bit damaging. Can I perhaps ping some of the folks in the linked issue?

Not looking for a verdict but more of a guideline. I believe new members to the community might seek the same.

At a personal level, while I don't think I qualify just yet I'd like be able to transform this guideline into some kind of milestone I could aim at.

I think it will be perfectly reasonable to at least put what happens currently. We owe it to people.

@unode
Copy link
Member Author

@unode unode commented Oct 29, 2020

I've removed the points and left the link to the discussion.
Until there's an official word this is more helpful than the TODO 😅

<para>Please note that contributors with commit rights unactive for more than
three months will have their commit rights revoked.</para>
Copy link
Contributor

@lukegb lukegb Nov 27, 2020

While you're here, it might be worth mentioning https://github.com/NixOS/rfcs/blob/master/rfcs/0055-retired-committers.md - so the policy would be something along the lines of "Please note that per RFC #55, contributors with commit rights to nixpkgs who are inactive for more than a year will become retired contributors."

...but that's also possibly worth a separate CL.

Copy link
Member Author

@unode unode Nov 27, 2020

Happy to integrate that in here since we didn't quite reach a conclusion.
Also, as you mentioned RFC, I'm wondering if we should morph the current discussion into one.
Any comments on this from the more active members following this discussion?

Copy link
Contributor

@lukegb lukegb Dec 1, 2020

@worldofpeace @cole-h I'm keen for this PR not to stall - any input on the above?

@domenkozar
Copy link
Member

@domenkozar domenkozar commented Dec 1, 2020

I agree that being honest about current state is better than a TODO.

Maybe this encourages someone to help out by improving the process, I'm unfortunately able to do only the minimal work to keep current status quo running.

@domenkozar domenkozar merged commit a0e24a6 into NixOS:master Dec 1, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants