Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liburing: fix cross-compilation #101810

merged 1 commit into from Oct 27, 2020


Copy link

@lopsided98 lopsided98 commented Oct 27, 2020

Motivation for this change

Cross-compilation of liburing was broken by #98869, because it caused --build and --host to be passed to a non-autotools configure script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits

cc @doronbehar @tobim @thoughtpolice

@doronbehar doronbehar merged commit c7f819c into NixOS:master Oct 27, 2020
19 checks passed
@lopsided98 lopsided98 deleted the liburing-cross-fix branch Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants