Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/mark-broken: improve #101812

Merged
merged 1 commit into from Oct 31, 2020
Merged

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 27, 2020

This improves on the previous verison of this script.

Previously it only accepted one attr, and required
explicit passing of the "broken" value.

This script is meant to be used to mark failing hydra builds as broken in the meta attrs
To use the script, you should pass the list of failing attrs as arguments to the script.

Example: cat failing-attrs | xargs ./pkgs/common-update/scripts/mark-broken

Generating a list of failing attrs: (this should be improved at a later date)

  • Go to the most recent hydra evaluation with all builds completed
  • Select the "builds still failing" tab
  • Highlight and select all packages, should be prefixed with nixpkgs.
  • Use regex and editor foo to leave only the attr names
  • Use the above example command to then execute the script

OTHER NOTES:

  • The denyFileList and denyAttrList will likely need to be updated slightly
    to align with the conventions used in nixpkgs at execution time
  • Any attrs which failed for any reason will be written to failed-marks.txt.
    Those attrs will likely need manual attention as disablement will likely be conditional.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
rm -f "$attr.fetchlog"
# broken should evaluate to true in any case now
markedSuccessfully=$(nix-instantiate --eval -E "with import ./. {}; $attr.meta.broken")
if [[ ! "$markedSuccessfully" == "true" ]]; then
Copy link
Member

@SuperSandro2000 SuperSandro2000 Oct 27, 2020

Suggested change
if [[ ! "$markedSuccessfully" == "true" ]]; then
if [[ "$markedSuccessfully" != "true" ]]; then

This improves on the previous verison of this script.

Previously it only accepted one attr, and required
explicit passing of the "broken" value.

This script is meant to be used to mark failing hydra builds as broken in the meta attrs
To use the script, you should pass the list of failing attrs as arguments to the script.

Example: `cat failing-attrs | xargs ./pkgs/common-update/scripts/mark-broken`

Generating a list of failing attrs: (this should be improved at a later date)
  - Go to the most recent hydra evaluation with all builds completed
  - Select the "builds still failing" tab
  - Highlight and select all packages, should be prefixed with `nixpkgs.`
  - Use regex and editor foo to leave only the attr names
  - Use the above example command to then execute the script

OTHER NOTES:
  - The `denyFileList` and `denyAttrList` will likely need to be updated slightly
    to align with the conventions used in nixpkgs at execution time
  - Any attrs which failed for any reason will be written to `failed-marks.txt`.
    Those attrs will likely need manual attention as disablement will likely be conditional.
@jonringer jonringer force-pushed the update-mark-broken-script branch from 49a621c to 8349d57 Oct 31, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 31, 2020

since this is largely only relevant to the next release manager, I'm going to merge

@jonringer jonringer merged commit 0544a7f into NixOS:master Oct 31, 2020
2 of 4 checks passed
@jonringer jonringer deleted the update-mark-broken-script branch Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants