Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flasm: init at 1.64 #101828

Merged
merged 1 commit into from Dec 21, 2020
Merged

flasm: init at 1.64 #101828

merged 1 commit into from Dec 21, 2020

Conversation

@siraben
Copy link
Member

@siraben siraben commented Oct 27, 2020

Motivation for this change

#81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Build on darwin:

Result of nixpkgs-review pr 101828 1

1 package built:
  • flasm

@siraben
Copy link
Member Author

@siraben siraben commented Nov 22, 2020

Result of nixpkgs-review pr 101828 1

1 package built:
  • flasm

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 20, 2020

Result of nixpkgs-review pr 101828 run on x86_64-linux 1

1 package built:
  • flasm

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 20, 2020

Result of nixpkgs-review pr 101828 run on x86_64-darwin 1

1 package built:
  • flasm

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 21, 2020

Result of nixpkgs-review pr 101828 run on x86_64-darwin 1

1 package built:
  • flasm

@SuperSandro2000 SuperSandro2000 merged commit 1de5611 into NixOS:master Dec 21, 2020
19 checks passed
@siraben siraben deleted the flasm-init branch Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants