Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxima: various cleanups #101830

Closed
wants to merge 5 commits into from
Closed

maxima: various cleanups #101830

wants to merge 5 commits into from

Conversation

@omasanori
Copy link
Contributor

@omasanori omasanori commented Oct 27, 2020

Motivation for this change

I have done some groundwork to ease not-yet-published update to Maxima 5.44.0. I published these cleanups separate from the update itself to make reviews easier.
I am still new to Nix so while I did my best some changes might not be idiomatic. Any suggestions are welcome!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@omasanori omasanori mentioned this pull request Oct 27, 2020
10 tasks
@omasanori omasanori mentioned this pull request Oct 27, 2020
10 tasks
Copy link
Member

@peti peti left a comment

Those gratuitous whitespace changes make it pretty hard to figure out what you've actually changed. I'm not a fan of submissions reformatting the entire file to their personal taste.

@omasanori
Copy link
Contributor Author

@omasanori omasanori commented Oct 28, 2020

Thank you for your reviews, @7c6f434c and @peti!

Those gratuitous whitespace changes make it pretty hard to figure out what you've actually changed. I'm not a fan of submissions reformatting the entire file to their personal taste.

I am sorry to bother you. I will revise the patch to minimize whitespace changes.

@omasanori omasanori force-pushed the maxima/cleanup-v2 branch from 787c5e1 to 210149e Oct 28, 2020
@omasanori
Copy link
Contributor Author

@omasanori omasanori commented Oct 28, 2020

So, the formatting seems closer now. Would you point out if any of these patches are irrelevant to you? I will adopt subsequent patches.

@omasanori omasanori requested a review from peti Oct 28, 2020
@omasanori omasanori force-pushed the maxima/cleanup-v2 branch 2 times, most recently from 918b805 to edbcc5d Oct 28, 2020
omasanori added 5 commits Oct 31, 2020
Since packages are inherited by default, `package ? null` does not work
as a declaration of optional dependency. To solve the problem, I added
`with*` flags and used them consistently.

With this change, the closure size of `maxima` was shrunk from 275429480
bytes to 213117176 bytes (reduced by 22.6%), and that of `maxima-ecl`
was done from 383156392 bytes to 326807728 bytes (reduced by 14.5%).

Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
This makes `patches` easier to read.

Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@omasanori omasanori force-pushed the maxima/cleanup-v2 branch from edbcc5d to 16d1ffa Oct 31, 2020
@omasanori
Copy link
Contributor Author

@omasanori omasanori commented Nov 2, 2020

So, I will rework this and Maxima update to make them acceptable. I appologize for my hasty action.

@omasanori omasanori closed this Nov 2, 2020
@omasanori omasanori deleted the maxima/cleanup-v2 branch Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants