Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv/check-meta: add hint to NIXPKGS_ALLOW_* for unfree/broken/… #101833

Merged
merged 1 commit into from Nov 5, 2020

Conversation

@wamserma
Copy link
Contributor

@wamserma wamserma commented Oct 27, 2020

A (slightly) different approach to https://github.com/NixOS/nixpkgs/pull/81990/files and more in line with #90031

Motivation for this change

#90031
Closes #81990

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (via building a marked package)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Oct 27, 2020

{ nixpkgs.config.allow${allow_attr} = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
Copy link
Member

@ghuntley ghuntley Oct 27, 2020

Is variable in the line below here correct?

Copy link
Contributor Author

@wamserma wamserma Oct 27, 2020

I only changed the enumeration here...

@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Nov 2, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Nov 2, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Nov 2, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

kisik21
kisik21 approved these changes Nov 5, 2020
Copy link
Contributor

@kisik21 kisik21 left a comment

LGTM.

If flakes weren't still experimental, I'd also add that they prevent Nix from reading the environment variables by default, which is mitigated by using the --impure flag.

@kisik21
Copy link
Contributor

@kisik21 kisik21 commented Nov 5, 2020

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from kevincox Nov 5, 2020
@kevincox kevincox merged commit e371443 into NixOS:master Nov 5, 2020
16 checks passed
@wamserma wamserma deleted the allow-via-env branch Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants