Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_bootstrap: disable failing timezone tests #101843

Merged
merged 1 commit into from Oct 27, 2020
Merged

go_bootstrap: disable failing timezone tests #101843

merged 1 commit into from Oct 27, 2020

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 27, 2020

Motivation for this change

Fixes https://hydra.nixos.org/build/129275183/nixlog/1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Oct 27, 2020

@ofborg build go_1_14 go_1_15

@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Oct 27, 2020

cc @FRidh @vcunat

staging-next looks like it's fine now but I don't want to merge this just in case it isn't.

vcunat
vcunat approved these changes Oct 27, 2020
Copy link
Member

@vcunat vcunat left a comment

Good for staging-next, I believe. It seems to succeed on master, perhaps the tzdata update was exactly in master..staging-next. Diff/approach looks OK to me at a quick glance, too.

@zowoq zowoq merged commit 8c9bb91 into NixOS:staging-next Oct 27, 2020
21 of 23 checks passed
@zowoq zowoq deleted the goboot branch Oct 27, 2020
@flokli flokli mentioned this pull request Nov 5, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants