Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teleprompter: 2.3.4 -> 2.4.0 #101844

Merged
merged 1 commit into from Oct 28, 2020
Merged

Conversation

@Scriptkiddi
Copy link
Contributor

@Scriptkiddi Scriptkiddi commented Oct 27, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sikmir
Copy link
Member

@sikmir sikmir commented Oct 27, 2020

@Scriptkiddi Scriptkiddi force-pushed the telepromter-2.4.0 branch from 2152c06 to e54b570 Oct 28, 2020
@Scriptkiddi Scriptkiddi force-pushed the telepromter-2.4.0 branch from e54b570 to d409a6f Oct 28, 2020
Copy link
Member

@mweinelt mweinelt left a comment

Does this also work against a more recent electron version?

error: Package ‘electron-4.2.12’ in /home/hexa/git/nixos/master/pkgs/development/tools/electron/generic.nix:8 is marked as insecure, refusing to evaluate.


Known issues:
 - Electron version 4.2.12 is EOL

@Scriptkiddi Scriptkiddi force-pushed the telepromter-2.4.0 branch from d409a6f to 9bb8fdf Oct 28, 2020
@Scriptkiddi
Copy link
Contributor Author

@Scriptkiddi Scriptkiddi commented Oct 28, 2020

@mweinelt done

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 28, 2020

Result of nixpkgs-review pr 101844 1

1 package built:
  • teleprompter

@mweinelt mweinelt merged commit 2755df8 into NixOS:master Oct 28, 2020
3 of 6 checks passed
@ajs124 ajs124 deleted the telepromter-2.4.0 branch Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants