Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.trezor: make udev rules dependency linux-only #101847

Merged
merged 1 commit into from Oct 30, 2020

Conversation

@mmilata
Copy link
Member

@mmilata mmilata commented Oct 27, 2020

Motivation for this change

Not possible to use package on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@1000101
Copy link
Member

@1000101 1000101 commented Oct 27, 2020

@GrahamcOfBorg build python3Packages.trezor

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

I think it is missing hardeningDisable = [ "strictoverflow" ]; for darwin because of many

clang-7: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
clang++ -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -I. -I../src -I/nix/store/65gmh01007csxmd6bbkvas8zkhlw0k7n-python3-3.8.6/include/python3.8 -c google/protobuf/pyext/descriptor_pool.cc -o build/temp.macosx-10.9-x86_64-3.8/google/protobuf/pyext/descriptor_pool.o -Wno-write-strings -Wno-invalid-offsetof -Wno-sign-compare -Wno-unused-variable -std=c++11 -Wno-shorten-64-to-32 -Wno-deprecated-register -Wno-shorten-64-to-32

but otherwise it builds.

@mmilata
Copy link
Member Author

@mmilata mmilata commented Oct 27, 2020

@SuperSandro2000 I think this package has no C/C++ sources, it's probably coming from a dependency - perhaps python3Packages.protobuf? That said I haven't actually tested this on darwin and will be grateful for any feedback.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 27, 2020

@SuperSandro2000 I think this package has no C/C++ sources, it's probably coming from a dependency - perhaps python3Packages.protobuf?

That sounds reasonable. I don't think it is a good idea to disable that flag for every package. We should probably disable it if clang is used on darwin.

That said I haven't actually tested this on darwin and will be grateful for any feedback.

I can't fully test it cause I don't own the hardware.

@mmahut mmahut merged commit 242441f into NixOS:master Oct 30, 2020
19 of 20 checks passed
@mmilata mmilata deleted the python-trezor-udev-linux branch Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants